fix code, update pylint, other goodies

.gitignore

@@ -6,3 +6,4 @@
 **/__pycache/
 .idea/
 .vscode/
+.venv/

Pipfile

@@ -1,23 +0,0 @@
-[[source]]
-name = "pypi"
-url = "https://pypi.org/simple"
-verify_ssl = true
-
-[dev-packages]
-flask = "*"
-pytest = "*"
-behave = "*"
-selenium = "*"
-webdriver_manager = "*"
-msedge-selenium-tools = "*"
-
-[packages]
-flask = "*"
-pytest = "*"
-behave = "*"
-selenium = "*"
-webdriver_manager = "*"
-msedge-selenium-tools = "*"
-
-[requires]
-python_version = "3.6"

README.md

@@ -1,2 +1,3 @@
 # behave-framework
+
 basic python test framework 

browserdriver/__init__.py

@@ -1,51 +1,38 @@
+# pylint: disable=too-few-public-methods
 from selenium import webdriver
 
-from msedge.selenium_tools import Edge, EdgeOptions
-from webdriver_manager.firefox import GeckoDriverManager
-from webdriver_manager.chrome import ChromeDriverManager
-from webdriver_manager.microsoft import EdgeChromiumDriverManager
-
 
 class BrowserDriver:
+
     @staticmethod
     def get(browser=None, headless=True):
-        if browser == "chrome":
+        valid_browsers = ['chrome', 'firefox', 'safari', 'edge']
-            return chrome(headless)
+        if browser in valid_browsers:
-        elif browser == "firefox":
+            browser_method = globals()[browser]
-            return firefox(headless)
+            return browser_method(headless)
-        elif browser == "edge":
+
-            return edge(headless)
+        raise ValueError(f"'{browser}' is not a supported browser")
-        elif browser == "safari":
-            return safari()
-        else:
-            raise ValueError("'{}' is not a supported browser".format(browser))
 
 
 def chrome(headless=True):
     options = webdriver.ChromeOptions()
     options.headless = headless
     options.add_argument('--ignore-certificate-errors')
-    return webdriver.Chrome(
+    return webdriver.Chrome(options=options)
-        ChromeDriverManager().install(),
-        options=options)
 
 
 def firefox(headless=True):
     options = webdriver.FirefoxOptions()
     options.accept_insecure_certs = True
     options.headless = headless
-    gecko_driver = GeckoDriverManager().install()
+    return webdriver.Firefox(options=options)
-    return webdriver.Firefox(
-        executable_path=gecko_driver,
-        options=options)
 
 
 def edge(headless=True):
-    options = EdgeOptions()
+    options = webdriver.EdgeOptions()
     options.use_chromium = True
     options.headless = headless
-    edge_driver = EdgeChromiumDriverManager().install()
+    driver = webdriver.Edge(options=options)
-    driver = Edge(edge_driver, options=options)
     return driver
 
 

conftest.py

@@ -1,6 +1,6 @@
 import configparser
-import pytest
 
+import pytest
 
 config = configparser.ConfigParser()
 

features/browser_demo.feature

@@ -1,4 +1,5 @@
 Feature: Browser Demo
+
   Scenario: Load test.io web page with chrome
     Given I have a chrome driver
     When I navigate to test.io
@@ -9,12 +10,12 @@ Feature: Browser Demo
     When I navigate to test.io
     Then The page is displayed
 
-  @skip
   Scenario: Load test.io web page with edge
     Given I have an edge driver
     When I navigate to test.io
     Then The page is displayed
 
+  @skip
   Scenario: Load test.io web page with safari
     Given I have a safari driver
     When I navigate to test.io

features/environment.py

@@ -1,5 +1,9 @@
-
+# pylint: disable=unused-argument
 def before_all(context):
     # -- SET LOG LEVEL: behave --logging-level=ERROR ...
     # on behave command-line or in "behave.ini".
     context.config.setup_logging()
+
+
+def after_scenario(context, scenario):
+    context.driver.quit()

features/steps/browser_demo.py

@@ -1,34 +1,34 @@
+# pylint: disable=no-name-in-module
 from behave import then, when, given
 
 from browserdriver import BrowserDriver
 
 
 @given('I have a firefox driver')
-def step_impl(context):
+def get_firefox_driver(context):
     context.driver = BrowserDriver.get("firefox")
 
 
 @given('I have a chrome driver')
-def step_impl(context):
+def get_chrome_driver(context):
     context.driver = BrowserDriver.get("chrome")
 
 
-@given(u'I have an edge driver')
+@given('I have an edge driver')
-def step_impl(context):
+def get_edge_driver(context):
     context.driver = BrowserDriver.get("edge")
 
 
-@given(u'I have a safari driver')
+@given('I have a safari driver')
-def step_impl(context):
+def get_safari_driver(context):
     context.driver = BrowserDriver.get("safari")
 
 
 @when('I navigate to test.io')
-def step_impl(context):
+def navigate_to_testio(context):
     context.driver.get("https://test.io")
-    print(context.driver.title)
 
 
 @then('The page is displayed')
-def step_impl(context):
+def page_is_displayed(context):
-    assert context.driver.title == "QA Testing as a Service | test IO"
+    assert context.driver.title == "Home | Test IO"

pytests/test_basic.py

@@ -1,5 +1,4 @@
 from browserdriver import BrowserDriver
-import pytest
 
 
 def test_firefox_browser(headless):
@@ -16,14 +15,13 @@ def test_chrome_browser(headless):
     bd.quit()
 
 
-def test_safari_browser(headless):
+def test_safari_browser():
     bd = BrowserDriver().get("safari", headless=False)
     bd.get('https://test.io')
     assert "QA Testing as a Service | test IO" == bd.title
     bd.quit()
 
 
-@pytest.mark.skip(reason="Edge has inconsistent implementations across platforms")
 def test_edge_browser(headless):
     bd = BrowserDriver().get("edge", headless=headless)
     bd.get('https://test.io')