From 34789c50a52958fb44d83793070fee4c85c28941 Mon Sep 17 00:00:00 2001 From: Greg Gauthier Date: Mon, 2 Mar 2026 22:19:47 +0000 Subject: [PATCH] test(cmd): improve error handling in completion test writer close Handle potential errors when closing the pipe writer in TestCompletionCmd, and use a deferred anonymous function to ignore errors in defer. --- cmd/completion_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cmd/completion_test.go b/cmd/completion_test.go index 4220463..842c3ea 100644 --- a/cmd/completion_test.go +++ b/cmd/completion_test.go @@ -26,10 +26,12 @@ func TestCompletionCmd(t *testing.T) { t.Fatal(err) } os.Stdout = w - defer w.Close() + defer func() { _ = w.Close() }() cmd := &cobra.Command{} completionCmd.Run(cmd, []string{tt.shell}) - w.Close() + if err := w.Close(); err != nil { + t.Errorf("close: %v", err) + } b, err := io.ReadAll(r) if err != nil { t.Fatal(err)