From 289f84f8a4210be3b2185f8427f020950de9bc65 Mon Sep 17 00:00:00 2001
From: Greg Gauthier <greg.gauthier@distributed.com>
Date: Sat, 20 Jul 2024 12:09:35 +0100
Subject: [PATCH] do a little reorganizing

---
 tests/helpers.py           | 15 +++++++++++++++
 tests/test_datadelivery.py | 15 +--------------
 2 files changed, 16 insertions(+), 14 deletions(-)
 create mode 100644 tests/helpers.py

diff --git a/tests/helpers.py b/tests/helpers.py
new file mode 100644
index 0000000..ed089ba
--- /dev/null
+++ b/tests/helpers.py
@@ -0,0 +1,15 @@
+import os
+import json
+
+
+CWD = os.path.dirname(os.path.realpath(__file__))
+
+
+####
+# HELPERS
+####
+def get_expected_response(test_name):
+    expected_response_file = test_name + ".json"
+    with open(os.path.join(CWD, 'expected_responses', expected_response_file), 'r') as file:
+        expected_response = json.load(file)
+        return expected_response
diff --git a/tests/test_datadelivery.py b/tests/test_datadelivery.py
index 539fa08..818281b 100644
--- a/tests/test_datadelivery.py
+++ b/tests/test_datadelivery.py
@@ -1,16 +1,14 @@
-import os
 import json
 import pytest
 from apiclient.client import api_client
 from apiclient.config import get_cfg
 from apiclient.oauth_helper import get_legacy_token
+from tests.helpers import get_expected_response
 
 
 ENV = 'qa'
 CFG = get_cfg(ENV)
 
-CWD = os.path.dirname(os.path.realpath(__file__))
-
 
 @pytest.fixture
 def api_call():
@@ -26,18 +24,7 @@ def api_call():
 
 
 def test_datadelivery_role_get(request, api_call):
-
     expected_response = get_expected_response(request.node.name)
     actual_response = api_client(api_call)
 
     assert json.dumps(actual_response, indent=4) == json.dumps(expected_response, indent=4)
-
-
-####
-# HELPERS
-####
-def get_expected_response(test_name):
-    expected_response_file = test_name + ".json"
-    with open(os.path.join(CWD, 'expected_responses', expected_response_file), 'r') as file:
-        expected_response = json.load(file)
-        return expected_response